Swa UI #343
Swa UI #343
Conversation
make buttons functional, improve ui, change terminology to git terminology (remove "load" and "save" verbs) Co-authored-by: Tom Beckmann <tomjonabc@gmail.com> and Eva Krebs <eva.krebs@hpi.de>
| SystemOrganization addCategory: #'SquotTonel-Tests'! | ||
| SystemOrganization addCategory: #'SquotTonel-Core'! |
There was a problem hiding this comment.
todo: fix commit errors!
| #slotOverrides : { }, | ||
| #objectsReplacedByNames : true, | ||
| #slotOverrides : IdentityDictionary { }, |
There was a problem hiding this comment.
todo: fix commit errors!
| title: 'Select changes and message for the new version'; | ||
| applyToWorkingCopy) | ||
| then: [:result | self refresh. aBlock value] | ||
| ifRejected: [:reason | nil])] |
There was a problem hiding this comment.
I recently fixed an issue here in the original method. See #341
| self withUnitOfWork: [ | ||
| self selectedRepository | ||
| loadVersion: self selectedCommit | ||
| interactive: aBoolean]. |
There was a problem hiding this comment.
loadVersion does not merge, it is rather like checkout or reset. Did you intend to use some flavor of mergeVersion instead?
| as yet unclassified | ||
| example | ||
|
|
||
| SBMorphExample |
There was a problem hiding this comment.
This example would not load in a clean image, since Sandblocks is not a dependency of Squot. Mind this for the final PR.
| createRepository | ||
|
|
||
| | repositoryPath | | ||
| directory := (FileDirectory default on: 'squot-repositories', FileDirectory slash, name) assureExistence. |
There was a problem hiding this comment.
Why not FileDirectory default / 'squot-repositories' / name?
| @@ -0,0 +1 @@ | |||
| (name 'Squit-ct.5' message 'empty log message' id 'f05de4c6-5f71-6f4c-9080-f5fd744b072c' date '30 August 2021' time '5:20:35.40661 pm' author 'ct' ancestors ((name 'Squit-ct.4' message 'empty log message' id '555ffaf2-7cbe-e747-9fd1-fc706de0aa88' date '30 August 2021' time '5:19:42.73361 pm' author 'ct' ancestors ((name 'Squit-cypress.1' message 'fabricated from a Cypress format repository' id '4a5f3775-51a1-2145-beb7-ebcdb560f31a' date '30 August 2021' time '3:16:59.539657 pm' author '' ancestors () stepChildren ())) stepChildren ())) stepChildren ()) | |||
There was a problem hiding this comment.
What is going on here? There should be no Monticello metadata here.
| assert: SquotTonelSerializer name | ||
| equals: ((snapshot artifactAt: 'src/Test') storeInfo serializer); | ||
| assert: ((snapshot artifactAt: 'src/Test') shadowOfTrackedObject respondsTo: #packageName) | ||
| description: 'not a SquotPackageShadow'. |
There was a problem hiding this comment.
Why delete something for this feature?
An incomplete list of what remains to be done: